¡Hola Edmund! El 2026-09-29 a las 13:04 +0200, Edmund Lodewijks escribió:
On 2026/09/29 10:05, Maximiliano Curia wrote: Thank you for your time and for reviewing it!
You are welcome, thanks for contributing your work to Debian!
I have a couple of suggestions for you to consider, these are not blockers, if you the package is fine as it is, I can upload it:
- The package doesn't have autopkgtest: Currently autopkgtest is one of the main mechanisms to detect regressions in the archive, so it's a good idea to add them to your packages, even if they only do a minimal smoketest. Since the package requires no compilation running the pytests in the autopkgtest is a good idea.
Let me find out how to add this. I am all for testing!
This is a good start: https://ci.debian.net/doc/file.TUTORIAL.html
- The package can be used as python module but the name of the package suggests an application: The package description says "It can be used from the command line or as a Python module.", if the later is the main way to use this package, or if other packages might use the python module, then it would be a good idea to split the desec-dns binary in python3-desec-dns (python module) and desec-dns (entry point). This might be overkill and you may want to decide this later. But, if you later decide to split the package, it will require going through the NEW queue again, so it make sense to think about this now.
Happy to split it into two packages, this makes sense to me.
In Archlinux one can use one PKGBUILD to create several packages. Can a similar thing be done for Debian, or would this involve two repos on Salsa (e.g. one with the Python Team, and one outside of it), etc etc?
It's a second binary package from the same source package, it doesn't require a second repository. To add the package you add a new paragraph in debian/control. Handling a package that builds more than one binary is slightly different than to handle a single one, as the target directory is debian/tmp instead of debian/$pkg, and then you need to install the files to the corresponding debian/$pkg from debian/tmp. I must say that taking a second look it makes little sense to split the package. :) Happy hacking, --"It is not the task of the University to offer what society asks for, but to give what society needs."
-- Edsger W. Dijkstra Saludos /\/\ /\ >< `/
signature.asc
Description: PGP signature
