Daniel John Debrunner wrote:
I think delaying the comment is fine.
I'm planning to commit this change before the end of this week, assuming
all the tests run for me.
Great!
One thing I do need is confirmation that the
copyright dates are correct in the files you've added. Some of them have
dates of 1997,2004 which seems unlikely, are all the new files meant to
have a copyright date of 2005? I can fix this if it is the case.
Yes, 2005 is correct.
I'm assuming that some performance tests will be run before this code
makes it as part of a release, comparing performance to 10.1/10.0 and
the performance impact of enabling query timeout.
Yes, I certainly plan to do performance testing of this.
rather than a new error XJ074.S, the existing generic error XJ081.S
(added by Shreyas) could have been used.
OK. Considering e.g. these existing codes (see below), it was not clear
to me what was the preferred way - adding a separate code or using a
generic one.
String INVALID_FETCH_SIZE = "XJ062.S";
String INVALID_MAX_ROWS_VALUE = "XJ063.S";
String INVALID_FETCH_DIRECTION = "XJ064.S";
String INVALID_ST_FETCH_SIZE = "XJ065.S";
String INVALID_MAXFIELD_SIZE = "XJ066.S";
--
Øyvind Bakksjø
Sun Microsystems, Web Services, Database Technology Group
Haakon VII gt. 7b, N-7485 Trondheim, Norway
Tel: x43419 / +47 73842119, Fax: +47 73842101
