[
https://issues.apache.org/jira/browse/DERBY-3294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555322#action_12555322
]
John H. Embretsen commented on DERBY-3294:
------------------------------------------
The patch DERBY-3294_diff_12_28.txt breaks the build - the file
checkToursDBTest.java
should be renamed to match the casing used in the source (CheckToursDBTest).
The source file's copyright statement should also be updated if such a
change is made.
Other than that, I have the following comments (mostly nitpicking):
@demo._Suite.java:
- two unused imports
@demo.checkToursDBTest.java:
- typo in class Javadoc: TourDB --> ToursDB
- some methods throw both SQLException and Exception, which seems
unnecessary.
- methods that can only throw SQLExeption should not declare that
they may throw any Exception (doDelete(), doUpdate())
- Javadoc for tearDown() method says "Tear-down the fixture by
removing the tables", but the tables are not removed.
- Other existing Javadoc is incomplete (e.g. missing/wrong @throws,
@param tags), while some methods have no Javadoc altogether.
- some comments on why the different parts of the test are not run as
individual test fixtures would be good for future reference.
> Convert demo/checkToursDB.java to junit
> ---------------------------------------
>
> Key: DERBY-3294
> URL: https://issues.apache.org/jira/browse/DERBY-3294
> Project: Derby
> Issue Type: Test
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Manjula Kutty
> Assignee: Manjula Kutty
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3294_diff_12_28.txt, DERBY-3294_stat_12_28.txt
>
>
> Place holder for the junit conversion of demo/checkToursDB.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
