[
https://issues.apache.org/jira/browse/DERBY-3294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556525#action_12556525
]
John H. Embretsen commented on DERBY-3294:
------------------------------------------
Manjula Kutty wrote:
> -The doSelect() asserts with the original number of rows. But after deleting
> the rows, those asserts will fail. So I thought not doing since the
> assertions will make sure the rows are deleted.
OK. I think what you are saying is that the number of rows deleted is asserted
in the doDelete() method, so there is no need to check this again by doing
another select count(*) after the deletes.
> - testToursDB() method's Javadoc specifies a wrong exception in the
> @throws tag. There is also a typo (tourdb --> ToursDB) in the Javadoc.
>
> Fixed
The typo is fixed, but it still specifies the wrong exception after the @throws
tag.
(If you are going to provide a new patch, it would be good to add a @param tag
for the CheckToursDBTest constructor as well.)
I have no further comments at this time, so I guess I'll leave the rest to a
committer...
> Convert demo/checkToursDB.java to junit
> ---------------------------------------
>
> Key: DERBY-3294
> URL: https://issues.apache.org/jira/browse/DERBY-3294
> Project: Derby
> Issue Type: Test
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Manjula Kutty
> Assignee: Manjula Kutty
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3294_diff_12_28.txt, DERBY-3294_stat_12_28.txt,
> DERBY_3294_diff_01_02.txt, DERBY_3294_diff_1_4.txt,
> DERBY_3294_stat_01_02.txt, DERBY_3294_stat_1_4.txt
>
>
> Place holder for the junit conversion of demo/checkToursDB.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
