[
https://issues.apache.org/jira/browse/DERBY-3294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556678#action_12556678
]
Myrna van Lunteren commented on DERBY-3294:
-------------------------------------------
I'm looking at committing this - and on the whole it looks good.
However, I wonder why the method insertMaps was introduced. Was it not possible
to use the insertMaps.main() method like the original test does?
I think it should...
The point of this test is to ensure that the toursDB created during compile is
correct/working. Using the toursdb created would be one way to do this. The
original test took another approach, and worked with the files in the demo
directory (the .sql files get copied to the built functionTests dir from the
java/demo source), mimicking the toursdb creation during the build using the
identical files as the build. Using insertMaps.main() as the original test
does, is identical to what happens to populate the MAPS table in the toursDB
database during the build process. (The java/demo/toursdb.build.xml does an ant
java call to insertMaps, which executes the main method).
However, in the conversion now, you've duplicated the code, rather than
actually using the available class, and thus, you're not actually testing the
code...
> Convert demo/checkToursDB.java to junit
> ---------------------------------------
>
> Key: DERBY-3294
> URL: https://issues.apache.org/jira/browse/DERBY-3294
> Project: Derby
> Issue Type: Test
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Manjula Kutty
> Assignee: Manjula Kutty
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3294_diff_12_28.txt, DERBY-3294_stat_12_28.txt,
> DERBY_3294_diff_01_02.txt, DERBY_3294_diff_1_4.txt, DERBY_3294_diff_1_7.txt,
> DERBY_3294_stat_01_02.txt, DERBY_3294_stat_1_4.txt, DERBY_3294_stat_1_7.txt
>
>
> Place holder for the junit conversion of demo/checkToursDB.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
