[
https://issues.apache.org/jira/browse/DERBY-3294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manjula Kutty updated DERBY-3294:
---------------------------------
Attachment: DERBY_3294_diff_01_02.txt
DERBY_3294_stat_01_02.txt
Thanks John for the comments. My replies are in line. Also please find the
updated patches. Please review them.
>The patch DERBY-3294_diff_12_28.txt breaks the build - the file
>>checkToursDBTest.java
>should be renamed to match the casing used in the source
>(CheckToursDBTest).
>The source file's copyright statement should also be updated if such a
>change is made.
It was my mistake. I created the test first with "checkToursDBTest.java" and
then moved it to the correct name format. But forgot to delete the older one,
and that followed every where.
>@demo._Suite.java:
>- two unused imports
Removed them
>@demo.checkToursDBTest.java:
>- typo in class Javadoc: TourDB --> ToursDB
Corrected
>- some methods throw both SQLException and Exception, which seems
>unnecessary.
Fixed
> - methods that can only throw SQLExeption should not declare that
> they may throw any Exception (doDelete(), doUpdate())
Done
> - Javadoc for tearDown() method says "Tear-down the fixture by
> removing the tables", but the tables are not removed.
Included dropping tables
> - Other existing Javadoc is incomplete (e.g. missing/wrong @throws,
> @param tags), while some methods have no Javadoc altogether.
Fixed
>- some comments on why the different parts of the test are not run as
> individual test fixtures would be good for future reference.
First I made each of the insert, delete and update in different fixtures. Then
since the order of running the fixtures are not fixed the test may fail in some
scenarios. So made all the methods in the same one test.
> Convert demo/checkToursDB.java to junit
> ---------------------------------------
>
> Key: DERBY-3294
> URL: https://issues.apache.org/jira/browse/DERBY-3294
> Project: Derby
> Issue Type: Test
> Components: Test
> Affects Versions: 10.4.0.0
> Reporter: Manjula Kutty
> Assignee: Manjula Kutty
> Priority: Minor
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3294_diff_12_28.txt, DERBY-3294_stat_12_28.txt,
> DERBY_3294_diff_01_02.txt, DERBY_3294_stat_01_02.txt
>
>
> Place holder for the junit conversion of demo/checkToursDB.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
