[
https://issues.apache.org/jira/browse/DERBY-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600781#action_12600781
]
Martin Zaun commented on DERBY-3531:
------------------------------------
> I ran the test 'SystemPrivilegesPermissionTest.java' on a Java ME platform
> without failures:
Glad to hear. Thanks for testing.
> I'm also running suites.All there, but expect it will be a while before it
> has completed (if I manage to run through it).
Of the tests I ran overnight, derbyall passed; but junit-all shows one error,
which seems unrelated to this patch:
<testcase
classname="org.apache.derbyTesting.functionTests.tests.jdbcapi.SetTransactionIsolationTest$1"
name="unknown" time="0.0">
<error message="The exception 'java.sql.SQLException: Limitation:
Record cannot be updated or inserted due to lack of space on the page. Use the
parameters derby.storage.pageSize and/or derby.storage.pageReservedSpace to
work around this limitation.' was thrown while evaluating an expression."
type="org.apache.derby.impl.jdbc.EmbedSQLException">java.sql.SQLException: The
exception 'java.sql.SQLException: Limitation: Record cannot be updated or
inserted due to lack of space on the page. Use the parameters
derby.storage.pageSize and/or derby.storage.pageReservedSpace to work around
this limitation.' was thrown while evaluating an expression.
at
org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(SQLExceptionFactory.java:45)
at org.apache.derby.impl.jdbc.Util.newEmbedSQLException(Util.java:87)
at org.apache.derby.impl.jdbc.Util.seeNextException(Util.java:223)
at
org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(TransactionResourceImpl.java:398)
at
org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(TransactionResourceImpl.java:346)
at
org.apache.derby.impl.jdbc.EmbedConnection.handleException(EmbedConnection.java:2183)
at
org.apache.derby.impl.jdbc.ConnectionChild.handleException(ConnectionChild.java:81)
at
org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1325)
at
org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(EmbedPreparedStatement.java:1652)
at
org.apache.derby.impl.jdbc.EmbedCallableStatement.executeStatement(EmbedCallableStatement.java:117)
at
org.apache.derby.impl.jdbc.EmbedPreparedStatement.execute(EmbedPreparedStatement.java:1307)
at
org.apache.derbyTesting.junit.CleanDatabaseTestSetup.compressObjects(CleanDatabaseTestSetup.java:287)
at
org.apache.derbyTesting.junit.CleanDatabaseTestSetup.cleanDatabase(CleanDatabaseTestSetup.java:166)
at
org.apache.derbyTesting.junit.CleanDatabaseTestSetup.setUp(CleanDatabaseTestSetup.java:109)
at junit.extensions.TestSetup$1.protect(TestSetup.java:20)
at junit.extensions.TestSetup.run(TestSetup.java:25)
at
org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57)
> Some general comments on the patch:
> 1) Inconsistent use of tabs and spaces. According to our guidelines spaces
> only are preferred, at least for newly added code.
I think I'd double-checked this: This patch removes (-) a couple of lines which
used blanks as indentation, but all the lines added (+) use tabs.
> 2) EmbedConnection.checkDatabaseCreatePrivileges: Is JavaDoc for '@param
> user' correct? (it mentions shutdown)
Right, this is incorrect (copy+paste error).
> 3) Isn't the comment below actually in SystemPrivilegesPermissionTest.policy?
> Missing the digit 1 at the end?
>
> +// PLEASE NOTE WHEN EDITING: This policy file is almost identical to
> +// SystemPrivilegesPermissionTest.policy
Right, this is incorrect (copy+paste error).
> My review was only partial, and I know very little about this subject, so
> another pair of eyes wouldn't hurt :)
Thanks for the review so far. I'll wait for more comments and will produce
another patch revision that will have the above comment issues fixed.
Martin
> DatabasePermission uses a JDK 1.4 method that is not present in
> J2ME/CDC/Foundation.
> ------------------------------------------------------------------------------------
>
> Key: DERBY-3531
> URL: https://issues.apache.org/jira/browse/DERBY-3531
> Project: Derby
> Issue Type: Sub-task
> Components: Security
> Reporter: Daniel John Debrunner
> Assignee: Martin Zaun
> Attachments: DERBY-3531-0.diff, DERBY-3531-0.stat
>
>
> causes abstract method errors once the class is used to check for database
> creation.
> From memory the method is String.split.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
