Rick Hillegas wrote:
Kristian Waagan wrote:
Kristian Waagan (JIRA) wrote:
[
https://issues.apache.org/jira/browse/DERBY-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601070#action_12601070
]
Kristian Waagan commented on DERBY-3531:
----------------------------------------
Thanks for the updated patch Martin.
I still see indentation issues though. Personally I try to never
include tabs in the code, but I don't think this has been documented
or formally decided for Derby.
Actually, seems we have tried to standardize this issue. However, the
documentation we have on it is not very clear or easy to follow.
Hi Kristian,
Here's what the community approved:
http://www.nabble.com/-VOTE---Approve-coding-conventions-for-the-Derby-project-td5771191.html
We are supposed to use spaces rather than tabs and indentation should be
4 spaces according to the included standard
(http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html). However,
we also allowed ourselves plenty of wiggle room in old code.
I don't like the wiggling part...
Note that I had found all the resources people have pointed me to so
far, but I still didn't think the indentation issue was clear.
I want a simple list, preferably the one mentioned in the mail thread
[1], that I can point contributers to;
1) 4 space indentation
2) No tabs
3) 80 character lines
We can mention the code convention document, but personally I don't want
it as an entry on the "hard-and-fast" rules list.
--
Kristian
[1]
http://www.nabble.com/forum/Permalink.jtp?root=5771191&post=5800416&page=y
The vote is documented on the wiki, but it is not easy to see what we
actually voted for. The contributer checklist on the wiki says we
haven't decided anything; "The Derby community has not approved a
common body of coding standards".
According to the vote, the coding standard was supposed to have been
copied onto the contributor checklist wiki page
(http://wiki.apache.org/db-derby/DerbyContributorChecklist). Looks like
that never happened. The "Coding Standard" line on that page looks stale
to me.
Maybe we should try to clear this up?
I agree that it would be a good idea to clean up the contributor checklist.
Regards,
-Rick
