Kristian Waagan (JIRA) wrote:
[ https://issues.apache.org/jira/browse/DERBY-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601070#action_12601070 ]
Kristian Waagan commented on DERBY-3531:
----------------------------------------
Thanks for the updated patch Martin.
I still see indentation issues though. Personally I try to never include tabs
in the code, but I don't think this has been documented or formally decided for
Derby.
Actually, seems we have tried to standardize this issue. However, the
documentation we have on it is not very clear or easy to follow.
The vote is documented on the wiki, but it is not easy to see what we
actually voted for. The contributer checklist on the wiki says we
haven't decided anything; "The Derby community has not approved a common
body of coding standards".
Maybe we should try to clear this up?
--
Kristian
For instance:
* StringUtil: new code uses tabs, except for on three lines in the middle.
* EmbedConnection: one new method uses tabs, another one uses spaces. There
are also tabs in the JavaDoc some places.
As far as I can tell, new code has been added with spaces only for quite some
time (with some exceptions).
DatabasePermission uses a JDK 1.4 method that is not present in
J2ME/CDC/Foundation.
------------------------------------------------------------------------------------
Key: DERBY-3531
URL: https://issues.apache.org/jira/browse/DERBY-3531
Project: Derby
Issue Type: Sub-task
Components: Security
Reporter: Daniel John Debrunner
Assignee: Martin Zaun
Attachments: DERBY-3531-0.diff, DERBY-3531-0.stat, DERBY-3531-1.diff,
DERBY-3531-1.stat
causes abstract method errors once the class is used to check for database
creation.
From memory the method is String.split.
