Github user ctubbsii commented on a diff in the pull request:
    --- Diff: 
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ ---
    @@ -120,16 +108,15 @@ public ScanBatch read() throws IOException, 
TabletClosedException {
           sawException = true;
    -      dataSource.close(true);
           throw ioe;
    -    } catch (RuntimeException re) {
    +    } catch (Exception e) {
    --- End diff --
    Careful about catching other RuntimeExceptions and wrapping them again with 
yet another RuntimeException. Also, try to pick a more specific 
RuntimeException, if possible. Perhaps `IllegalStateException`, 
`IllegalArgumentException`, or `UncheckedIOException`.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to