Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/159#discussion_r83735883
  
    --- Diff: 
core/src/main/java/org/apache/accumulo/core/iterators/SortedKeyValueIterator.java
 ---
    @@ -147,4 +147,13 @@
        *              if not supported.
        */
       SortedKeyValueIterator<K,V> deepCopy(IteratorEnvironment env);
    +
    +  /**
    +   * Closes the Iterator. This must be overridden by the implementing 
class that has access to <tt>SortedKeyValueIterator source</tt> provided in the
    --- End diff --
    
    This should say "should be overridden". Or it should say that it "is 
expected that". Clearly it's not a "must" situation, since the default method 
does exist, and allows them to avoid it. This could cause problems mixing 
legacy iterators with new iterators, as the new ones will be expected to be 
closed, but the legacy ones won't close them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to