Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r83737095
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/ClientSideIteratorScanner.java
---
@@ -257,26 +257,19 @@ public void setSource(final Scanner scanner) {
tm.put(iterInfo.getPriority(), iterInfo);
}
- SortedKeyValueIterator<Key,Value> skvi;
- try {
- skvi = IteratorUtil.loadIterators(smi, tm.values(),
serverSideIteratorOptions, new
ClientSideIteratorEnvironment(getSamplerConfiguration() != null,
- getIteratorSamplerConfigurationInternal()), false, null);
- } catch (IOException e) {
- throw new RuntimeException(e);
- }
+ try (SortedKeyValueIterator<Key,Value> skvi =
IteratorUtil.loadIterators(smi, tm.values(), serverSideIteratorOptions, new
ClientSideIteratorEnvironment(
+ getSamplerConfiguration() != null,
getIteratorSamplerConfigurationInternal()), false, null)) {
- final Set<ByteSequence> colfs = new TreeSet<>();
- for (Column c : this.getFetchedColumns()) {
- colfs.add(new ArrayByteSequence(c.getColumnFamily()));
- }
+ final Set<ByteSequence> colfs = new TreeSet<>();
+ for (Column c : this.getFetchedColumns()) {
+ colfs.add(new ArrayByteSequence(c.getColumnFamily()));
+ }
- try {
skvi.seek(range, colfs, true);
+ return new IteratorAdapter(skvi);
--- End diff --
Won't turning this into a try-with-resources cause the new `skvi` returned
in this `IteratorAdapter` to be closed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
