Github user ctubbsii commented on a diff in the pull request:
    --- Diff: 
    @@ -16,20 +16,65 @@
     package org.apache.accumulo.server.metrics;
    +import java.util.HashMap;
    +import java.util.Map;
     import org.apache.hadoop.metrics2.MetricsSystem;
     import org.apache.hadoop.metrics2.lib.DefaultMetricsSystem;
    +import org.apache.hadoop.metrics2.source.JvmMetrics;
    +import org.apache.hadoop.metrics2.source.JvmMetricsInfo;
     public class MetricsSystemHelper {
    +  private static Map<String,String> serviceNameMap = new HashMap<>();
    +  private static String processName = "Unknown";
    +  static {
    +    serviceNameMap.put("master", "Master");
    +    serviceNameMap.put("tserver", "TabletServer");
    +    serviceNameMap.put("monitor", "Monitor");
    +    serviceNameMap.put("gc", "GarbageCollector");
    +    serviceNameMap.put("tracer", "Tracer");
    +    serviceNameMap.put("shell", "Shell");
    --- End diff --
    What is this mapping for? Seems strange to do it here.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to