Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/291#discussion_r133086736
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/metrics/MetricsSystemHelper.java
---
@@ -16,20 +16,65 @@
*/
package org.apache.accumulo.server.metrics;
+import java.util.HashMap;
+import java.util.Map;
+
import org.apache.hadoop.metrics2.MetricsSystem;
import org.apache.hadoop.metrics2.lib.DefaultMetricsSystem;
+import org.apache.hadoop.metrics2.source.JvmMetrics;
+import org.apache.hadoop.metrics2.source.JvmMetricsInfo;
/**
*
*/
public class MetricsSystemHelper {
+ private static Map<String,String> serviceNameMap = new HashMap<>();
+ private static String processName = "Unknown";
+
+ static {
+ serviceNameMap.put("master", "Master");
+ serviceNameMap.put("tserver", "TabletServer");
+ serviceNameMap.put("monitor", "Monitor");
+ serviceNameMap.put("gc", "GarbageCollector");
+ serviceNameMap.put("tracer", "Tracer");
+ serviceNameMap.put("shell", "Shell");
+ }
+
+ public static void configure(String application) {
+ String serviceName = application;
+ if (MetricsSystemHelper.serviceNameMap.containsKey(application)) {
+ serviceName = MetricsSystemHelper.serviceNameMap.get(application);
+ }
+
+ // a system property containing 'instance' can be used if more than
one TabletServer is started on a host
+ String serviceInstance = "";
+ if (serviceName.equals("TabletServer")) {
+ for (Map.Entry<Object,Object> p : System.getProperties().entrySet())
{
+ if (((String) p.getKey()).contains("instance")) {
+ // get rid of all non-alphanumeric characters and then prefix
with a -
+ serviceInstance = "-" + ((String)
p.getValue()).replaceAll("[^a-zA-Z0-9]", "");
--- End diff --
I think it'd be better to simply pass through what was put in the property,
rather than parse in code what is provided in the process' environment. It
makes too many assumptions about the launch environment inside code. If a
specific format is desired, the launch script/environment should be tweaked to
use the desired format.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
