Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2174#discussion_r200757804
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/converter/message/JMSMappingOutboundTransformerTest.java
---
@@ -361,7 +361,7 @@ public void
testConvertEmptyObjectMessageToAmqpMessageWithAmqpValueBody() throws
assertNotNull(amqp.getBody());
assertTrue(amqp.getBody() instanceof AmqpValue);
assertTrue(((AmqpValue) amqp.getBody()).getValue() instanceof
Binary);
- assertEquals(0, ((Binary) ((AmqpValue)
amqp.getBody()).getValue()).getLength());
+ assertEquals(5, ((Binary) ((AmqpValue)
amqp.getBody()).getValue()).getLength());
--- End diff --
I thought the same, but I looked around at the other tests and several of
them were using 5 in their assertions. If the assertion uses 0 the test fails
so that indicates a problem with the implementation rather than the test, of
course.
---
