Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2174#discussion_r201026341
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/converter/message/JMSMappingOutboundTransformerTest.java
---
@@ -361,7 +361,7 @@ public void
testConvertEmptyObjectMessageToAmqpMessageWithAmqpValueBody() throws
assertNotNull(amqp.getBody());
assertTrue(amqp.getBody() instanceof AmqpValue);
assertTrue(((AmqpValue) amqp.getBody()).getValue() instanceof
Binary);
- assertEquals(0, ((Binary) ((AmqpValue)
amqp.getBody()).getValue()).getLength());
+ assertEquals(5, ((Binary) ((AmqpValue)
amqp.getBody()).getValue()).getLength());
--- End diff --
@gemmellr that is correct!
@tabish121 the fix you added only works if AMQP->Core->AMQP.. it has
nothing to do with the conversion itself. So.. I will keep the work around for
now.. but I consider fixing it quite a blocker for releasing master again. I
will add a JIRA with a blocker uppercase.. meaning.. we need to fix
LargeMesasges for AMQP.
---
