Github user tabish121 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2174#discussion_r200759349
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/converter/message/JMSMappingOutboundTransformerTest.java
---
@@ -361,7 +361,7 @@ public void
testConvertEmptyObjectMessageToAmqpMessageWithAmqpValueBody() throws
assertNotNull(amqp.getBody());
assertTrue(amqp.getBody() instanceof AmqpValue);
assertTrue(((AmqpValue) amqp.getBody()).getValue() instanceof
Binary);
- assertEquals(0, ((Binary) ((AmqpValue)
amqp.getBody()).getValue()).getLength());
+ assertEquals(5, ((Binary) ((AmqpValue)
amqp.getBody()).getValue()).getLength());
--- End diff --
I'm back to work on Monday and can look closer, a quite look at the
equivalent tests in 5.x show that they all test for 0 as the expected length so
I'm not sure why these are checking for 5 now, that seems wrong to me but I'd
have to look closer when I'm back.
---
