Github user tabish121 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2174#discussion_r201007171
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/converter/message/JMSMappingOutboundTransformerTest.java
---
@@ -361,7 +361,7 @@ public void
testConvertEmptyObjectMessageToAmqpMessageWithAmqpValueBody() throws
assertNotNull(amqp.getBody());
assertTrue(amqp.getBody() instanceof AmqpValue);
assertTrue(((AmqpValue) amqp.getBody()).getValue() instanceof
Binary);
- assertEquals(0, ((Binary) ((AmqpValue)
amqp.getBody()).getValue()).getLength());
+ assertEquals(5, ((Binary) ((AmqpValue)
amqp.getBody()).getValue()).getLength());
--- End diff --
@clebertsuconic once you have something better that is tested and working,
sure you can revert this, but for now those of us getting messages that fall
into the "large" message trap see unreliable transformations so this fix is
needed. Once the broker does it better then you can removed these workarounds
if you know for sure that conversions are only every one way.
---
