Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2434#discussion_r234532241
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
---
@@ -3178,138 +3187,7 @@ public Queue createQueue(final SimpleString address,
final int consumersBeforeDispatch,
final long delayBeforeDispatch,
final boolean autoCreateAddress) throws
Exception {
- return createQueue(address, routingType, queueName, filterString,
user, durable, temporary, ignoreIfExists, transientQueue, autoCreated,
maxConsumers, purgeOnNoConsumers, exclusive, lastValue, lastValueKey,
nonDestructive, consumersBeforeDispatch, delayBeforeDispatch,
autoCreateAddress, false);
- }
-
- private Queue createQueue(final SimpleString address,
--- End diff --
So afaik, the one being removed is the main one called by bits like config
loader etc and invoked more directly by many other code paths, so it would be
better to remove the other if any IMO.
---
