[GitHub] activemq-artemis pull request #2434: ARTEMIS-1867 FQQN for producers

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2434#discussion_r234540655
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
 ---
    @@ -3178,138 +3187,7 @@ public Queue createQueue(final SimpleString address,
                                 final int consumersBeforeDispatch,
                                 final long delayBeforeDispatch,
                                 final boolean autoCreateAddress) throws 
Exception {
    -      return createQueue(address, routingType, queueName, filterString, 
user, durable, temporary, ignoreIfExists, transientQueue, autoCreated, 
maxConsumers, purgeOnNoConsumers, exclusive, lastValue, lastValueKey, 
nonDestructive, consumersBeforeDispatch, delayBeforeDispatch, 
autoCreateAddress, false);
    -   }
    -
    -   private Queue createQueue(final SimpleString address,
    --- End diff --
    
    Thanks, i was going to flag about configurationManaged not being present on 
the other, but have noticed since you've added it, so it shouldn't be an issue.



---