Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2434#discussion_r239497231
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/BindingsImpl.java
 ---
    @@ -53,7 +54,13 @@
     
        private final Map<SimpleString, Integer> routingNamePositions = new 
ConcurrentHashMap<>();
     
    -   private final Map<Long, Binding> bindingsMap = new 
ConcurrentHashMap<>();
    +   private final Map<Long, Binding> bindingsIdMap = new 
ConcurrentHashMap<>();
    --- End diff --
    
    It won't use Long instances by just primitive longs, so just footprint: if 
you know that the map won't be that big i suppose that's fine anyway


---

Reply via email to