onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer
connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253880048
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java
##########
@@ -47,7 +47,8 @@
SESSION_CREATED(26),
SESSION_CLOSED(27),
MESSAGE_DELIVERED(28),
- MESSAGE_EXPIRED(29);
+ MESSAGE_EXPIRED(29),
+ CONNECTION_CONNECTED(30);
Review comment:
```
if (hasBrokerSessionPlugins()) {
callBrokerSessionPlugins(plugin -> plugin.afterCreateSession(session));
}
```
SESSION_CREATED will only be sent if BrokerSessionPlugins is turned on in
the configuration file.
Also the notifications of CONNECTION_CREATE and SESSIONTION_CREATE will be
filtered and will not be sent to other nodes in the cluster.You can see
`ClusterConnectionBridge.setupNotificationConsumer()` method, where the
cluster-connection filter is set .
This is why I want to modify the filtering rules, CONNECTION_CREATE,
SESSIONTION_CREATE and other connection-related notifications, only can use the
`ManagementNotificationAddress` address to route messages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
