onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer
connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r255983228
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionBridge.java
##########
@@ -351,10 +355,15 @@ private String appendIgnoresToFilter(String
filterString) {
}
filterString += "!" + storeAndForwardPrefix;
filterString += ",!" + managementAddress;
- filterString += ",!" + managementNotificationAddress;
return filterString;
}
+ private String createPermissiveManagementNotificationToFilter() {
+ StringBuilder filterBuilder = new
StringBuilder(ManagementHelper.HDR_NOTIFICATION_TYPE).append(" = '")
Review comment:
The inter-cluster notification message needs to specify the routing address
to route the message. Different from the notifications of CONSUMER_CREATE and
BINDING_ADD, the routing address (the address created or consumed by itself)
has been determined before the notification is sent. When sending a
SESSION_CREATED notification, We can't know which address to use, so I chose to
use the `ManagementManagementAddress`, which is consumed by each node in the
cluster-connection.
But the notification message using the `ManagementNotificationAddress`
address is filtered by the filter, so I modified the filter and allow
SESSION_CREATED notification to be routed to other nodes in the cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
