onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer
connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253882381
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java
##########
@@ -47,7 +47,8 @@
SESSION_CREATED(26),
SESSION_CLOSED(27),
MESSAGE_DELIVERED(28),
- MESSAGE_EXPIRED(29);
+ MESSAGE_EXPIRED(29),
+ CONNECTION_CONNECTED(30);
Review comment:
```
private void handleNotificationMessage(ClientMessage message,
CoreNotificationType ntype) throws Exception {
// TODO - optimised this by just passing int in header - but filter
needs to be extended to support IN with
switch (ntype) {
case BINDING_ADDED: {
doBindingAdded(message);
break;
}
case BINDING_REMOVED: {
doBindingRemoved(message);
break;
}
case CONSUMER_CREATED: {
doConsumerCreated(message);
break;
}
case CONSUMER_CLOSED: {
doConsumerClosed(message);
break;
}
case PROPOSAL: {
doProposalReceived(message);
break;
}
case PROPOSAL_RESPONSE: {
doProposalResponseReceived(message);
break;
}
case UNPROPOSAL: {
doUnProposalReceived(message);
break;
}
default: {
throw ActiveMQMessageBundle.BUNDLE.invalidType(ntype);
}
}
}
```
Only these notifications will pass between cluster nodes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
