onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer
connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r255985412
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionBridge.java
##########
@@ -351,10 +355,15 @@ private String appendIgnoresToFilter(String
filterString) {
}
filterString += "!" + storeAndForwardPrefix;
filterString += ",!" + managementAddress;
- filterString += ",!" + managementNotificationAddress;
return filterString;
}
+ private String createPermissiveManagementNotificationToFilter() {
+ StringBuilder filterBuilder = new
StringBuilder(ManagementHelper.HDR_NOTIFICATION_TYPE).append(" = '")
Review comment:
Although it is possible to add a dedicated address to the SESSION_CREATED
notification when the cluster-connection is created, it is not necessary to do
so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
