or "expected_by" i like expected_by over need_by On Tue, Feb 25, 2025 at 6:26 AM Ash Berlin-Taylor <a...@apache.org> wrote:
> Breaking with the herd/answering a question you didn’t even ask > (:evil-grin:) > > How about changing need_by to landing_time, i.e. > > `landing_time = DeadlineReference.DAGRUN_QUEUED + timedelta(hours=1)` > > Or some variation there of - `landed_by` etc. > -ash > > > > > On 25 Feb 2025, at 05:15, Ankit Chaurasia <sunank...@gmail.com> wrote: > > > > DeadlineReference +1. > > > > Regards, > > *Ankit Chaurasia* > > > > > > > > > > > > > > > > On Tue, 25 Feb 2025 at 10:05, Pavankumar Gopidesu < > gopidesupa...@gmail.com> > > wrote: > > > >> +1 `DeadlineReference` > >> > >> Regards > >> Pavan Kumar > >> > >> On Tue, Feb 25, 2025, 04:11 Amogh Desai <amoghdesai....@gmail.com> > wrote: > >> > >>> Late to the party, but I'd vote for `DeadlineReference` too. Concise > and > >>> does the job well. > >>> > >>> Thanks & Regards, > >>> Amogh Desai > >>> > >>> > >>> On Tue, Feb 25, 2025 at 7:56 AM Wei Lee <weilee...@gmail.com> wrote: > >>> > >>>> A bit late to the party, but DeadlineReference +1. > >>>> > >>>> Best, > >>>> Wei > >>>> > >>>>> On Feb 25, 2025, at 4:02 AM, Daniel Standish > >>>> <daniel.stand...@astronomer.io.invalid> wrote: > >>>>> > >>>>> Stewing presently thank you :) > >>>>> > >>>>> On Mon, Feb 24, 2025 at 11:53 AM Ferruzzi, Dennis > >>>>> <ferru...@amazon.com.invalid> wrote: > >>>>> > >>>>>> Alright then. DeadlineReference gets the green light for now! If > >>>> anyone > >>>>>> has a suggestion they like more, please feel free to drop it in > >> here. > >>>> I'm > >>>>>> working on some Ariflow3.0 stuff before I get back to this, so > >> there's > >>>>>> plenty of time before this is set down if anyone wants to stew on > >> it a > >>>> bit. > >>>>>> > >>>>>> Thanks for the thoughts, all! > >>>>>> > >>>>>> > >>>>>> - ferruzzi > >>>>>> > >>>>>> > >>>>>> ________________________________ > >>>>>> From: Jarek Potiuk <ja...@potiuk.com> > >>>>>> Sent: Monday, February 24, 2025 11:11 AM > >>>>>> To: dev@airflow.apache.org > >>>>>> Subject: RE: [EXT] Two Hard Things: Deadline Alerts Edition > >>>>>> > >>>>>> CAUTION: This email originated from outside of the organization. Do > >>> not > >>>>>> click links or open attachments unless you can confirm the sender > >> and > >>>> know > >>>>>> the content is safe. > >>>>>> > >>>>>> > >>>>>> > >>>>>> AVERTISSEMENT: Ce courrier électronique provient d’un expéditeur > >>>> externe. > >>>>>> Ne cliquez sur aucun lien et n’ouvrez aucune pièce jointe si vous ne > >>>> pouvez > >>>>>> pas confirmer l’identité de l’expéditeur et si vous n’êtes pas > >> certain > >>>> que > >>>>>> le contenu ne présente aucun risque. > >>>>>> > >>>>>> > >>>>>> > >>>>>> Yep. DaeadlineReference is good . > >>>>>> > >>>>>> > >>>>>> On Mon, Feb 24, 2025 at 8:07 PM Mehta, Shubham > >>>> <shu...@amazon.com.invalid> > >>>>>> wrote: > >>>>>> > >>>>>>> +1 to DeadlineReference. It is clear and allows flexibility to > >> choose > >>>> any > >>>>>>> reference point. > >>>>>>> > >>>>>>> shubham > >>>>>>> > >>>>>>> On 2025-02-24, 10:00 AM, "Ferruzzi, Dennis" > >>> <ferru...@amazon.com.inva > >>>>>>> <mailto:ferru...@amazon.com.inva>LID> wrote: > >>>>>>> > >>>>>>> > >>>>>>> CAUTION: This email originated from outside of the organization. Do > >>> not > >>>>>>> click links or open attachments unless you can confirm the sender > >> and > >>>>>> know > >>>>>>> the content is safe. > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> AVERTISSEMENT: Ce courrier électronique provient d’un expéditeur > >>>> externe. > >>>>>>> Ne cliquez sur aucun lien et n’ouvrez aucune pièce jointe si vous > >> ne > >>>>>> pouvez > >>>>>>> pas confirmer l’identité de l’expéditeur et si vous n’êtes pas > >>> certain > >>>>>> que > >>>>>>> le contenu ne présente aucun risque. > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> Hey folks. I need to narrow down the name for one of the parameters > >>> on > >>>>>> the > >>>>>>> Deadline Alerts work and I'm fishing for suggestions. > >>>>>>> > >>>>>>> > >>>>>>> TLDR: need_by_date = {some existing timestamp} + {a user-defined > >>>>>> timedelta} > >>>>>>> > >>>>>>> > >>>>>>> The existing timestamp could be dynamic (like when the dagrun is > >>> queued > >>>>>> or > >>>>>>> when a specific task stars, etc), or fixed datetime. > >>>>>>> > >>>>>>> > >>>>>>> So in practice this will look something like: > >>>>>>> > >>>>>>> > >>>>>>> need_by = DeadlineTrigger.DAGRUN_QUEUED + timedelta(hours=1) > >>>>>>> > >>>>>>> > >>>>>>> where the DeadlineTrigger is the part we are trying to rename. > >>>>>>> > >>>>>>> > >>>>>>> I initially used Anchor in the AIP for lack of a better name and it > >>> was > >>>>>>> universally hated. I like Trigger better, but that name is already > >>>>>>> overloaded in Airflow so I don't want to reuse it. Maybe Reference? > >>>>>>> > >>>>>>> > >>>>>>> need_by = DeadlineReference.DAGRUN_STARTED + timedelta(minutes=30? > >>>>>>> > >>>>>>> > >>>>>>> Please throw some other suggestions or naming thoughts on the pile > >>> and > >>>>>>> maybe we can come up with something good. > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> - ferruzzi > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>> > >>>> > >>>> > >>> > >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@airflow.apache.org > For additional commands, e-mail: dev-h...@airflow.apache.org > >
