Stewing presently thank you :) On Mon, Feb 24, 2025 at 11:53 AM Ferruzzi, Dennis <ferru...@amazon.com.invalid> wrote:
> Alright then. DeadlineReference gets the green light for now! If anyone > has a suggestion they like more, please feel free to drop it in here. I'm > working on some Ariflow3.0 stuff before I get back to this, so there's > plenty of time before this is set down if anyone wants to stew on it a bit. > > Thanks for the thoughts, all! > > > - ferruzzi > > > ________________________________ > From: Jarek Potiuk <ja...@potiuk.com> > Sent: Monday, February 24, 2025 11:11 AM > To: dev@airflow.apache.org > Subject: RE: [EXT] Two Hard Things: Deadline Alerts Edition > > CAUTION: This email originated from outside of the organization. Do not > click links or open attachments unless you can confirm the sender and know > the content is safe. > > > > AVERTISSEMENT: Ce courrier électronique provient d’un expéditeur externe. > Ne cliquez sur aucun lien et n’ouvrez aucune pièce jointe si vous ne pouvez > pas confirmer l’identité de l’expéditeur et si vous n’êtes pas certain que > le contenu ne présente aucun risque. > > > > Yep. DaeadlineReference is good . > > > On Mon, Feb 24, 2025 at 8:07 PM Mehta, Shubham <shu...@amazon.com.invalid> > wrote: > > > +1 to DeadlineReference. It is clear and allows flexibility to choose any > > reference point. > > > > shubham > > > > On 2025-02-24, 10:00 AM, "Ferruzzi, Dennis" <ferru...@amazon.com.inva > > <mailto:ferru...@amazon.com.inva>LID> wrote: > > > > > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and > know > > the content is safe. > > > > > > > > > > > > > > AVERTISSEMENT: Ce courrier électronique provient d’un expéditeur externe. > > Ne cliquez sur aucun lien et n’ouvrez aucune pièce jointe si vous ne > pouvez > > pas confirmer l’identité de l’expéditeur et si vous n’êtes pas certain > que > > le contenu ne présente aucun risque. > > > > > > > > > > > > > > Hey folks. I need to narrow down the name for one of the parameters on > the > > Deadline Alerts work and I'm fishing for suggestions. > > > > > > TLDR: need_by_date = {some existing timestamp} + {a user-defined > timedelta} > > > > > > The existing timestamp could be dynamic (like when the dagrun is queued > or > > when a specific task stars, etc), or fixed datetime. > > > > > > So in practice this will look something like: > > > > > > need_by = DeadlineTrigger.DAGRUN_QUEUED + timedelta(hours=1) > > > > > > where the DeadlineTrigger is the part we are trying to rename. > > > > > > I initially used Anchor in the AIP for lack of a better name and it was > > universally hated. I like Trigger better, but that name is already > > overloaded in Airflow so I don't want to reuse it. Maybe Reference? > > > > > > need_by = DeadlineReference.DAGRUN_STARTED + timedelta(minutes=30? > > > > > > Please throw some other suggestions or naming thoughts on the pile and > > maybe we can come up with something good. > > > > > > > > > > - ferruzzi > > > > > > > > >
