Yes the upgrade makes many issues I found that [inlinepatterns](https://github.com/Python-Markdown/markdown/blob/master/markdown/inlinepatterns.py) is changed from [previous](https://github.com/DataDog/Python-Markdown/blob/master/markdown/inlinepatterns.py) So LinkPattern, sanitize function like things were removed/changed So I also think doing upgrade to current version of py md brings lot of core changes.
I added more emojis from previous package diff is [here](https://forge-allura.apache.org/u/shalithasuranga/allura/ci/2b478e053b0d1ab157ac59411140b68e7d44d7b2/) . Advantage is if we write our own extension it may not affect with library upgrades and also we use unicodes not images so existing emoji js will take care. I found that 4 cases failing there related to macro such as `allura.tests.test_globals.test_macro_members` even for the last commit from upstream(without these changes) but those macros are working properly manually. I am not sure where is the issue. will check --- ** [tickets:#6923] Handle github emoji** **Status:** in-progress **Milestone:** unreleased **Labels:** github import **Created:** Tue Nov 26, 2013 11:00 PM UTC by Dave Brondsema **Last Updated:** Wed Oct 17, 2018 08:42 PM UTC **Owner:** nobody Emoji (e.g. :+1: thumbs up) are heavily used on some GH projects and would be good to carry over during import. However, the images are not licensed for us to redistribute https://github.com/github/gemoji/blob/master/LICENSE Maybe we could use https://github.com/Genshin/PhantomOpenEmoji if the mapping is straightforward. We also need to decide if we want an emoji-like feature throughout our markdown or handle this just at import. --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
