Cool, good testing. Makes me think about native browser support for emoji, where twemoji isn't even need. I'll make a ticket for that and several other emoji ideas for next or later
This does look good, go ahead with test cases. That regex looks pretty crazy, but I figure its since some short codes have those characters in them. Tests with one or two of those might be good to include. Then I'll do a final review --- ** [tickets:#6923] Handle github emoji** **Status:** in-progress **Milestone:** unreleased **Labels:** github import **Created:** Tue Nov 26, 2013 11:00 PM UTC by Dave Brondsema **Last Updated:** Mon Oct 22, 2018 07:31 AM UTC **Owner:** nobody Emoji (e.g. :+1: thumbs up) are heavily used on some GH projects and would be good to carry over during import. However, the images are not licensed for us to redistribute https://github.com/github/gemoji/blob/master/LICENSE Maybe we could use https://github.com/Genshin/PhantomOpenEmoji if the mapping is straightforward. We also need to decide if we want an emoji-like feature throughout our markdown or handle this just at import. --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
