----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39283/#review102516 -----------------------------------------------------------
It seems like you're missing a bunch of services and all configurations. Instead of trying to get skeleton packs in, you should be focusing on a single pack and getting it complete the first time. Also, none of the groups had summary information. We should be as verbose as possible in these upgrade packs so that we can tell what's actually going on during the upgrade. ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml (line 20) <https://reviews.apache.org/r/39283/#comment160200> This is missing a lot of services that exist in the rolling upgrade pack. ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml (line 23) <https://reviews.apache.org/r/39283/#comment160197> Shouldn't we name this EXPRESS to be consistent? Same with the file names; nonrolling-upgrade-2.3.xml should be express-upgrade-2.3.xml ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml (lines 137 - 140) <https://reviews.apache.org/r/39283/#comment160198> What is this empty group? If we're using this as a way to stop the upgrade at a certain point, there are cleaner ways (like having a manual task). ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml (lines 142 - 143) <https://reviews.apache.org/r/39283/#comment160199> You're missing `unlink_all_configs` which is required for downgrade from 2.3 to 2.2 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml (line 20) <https://reviews.apache.org/r/39283/#comment160202> Missing a bunch of services. ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml (lines 137 - 140) <https://reviews.apache.org/r/39283/#comment160201> I'm not sure what this is, but it looks wrong. - Jonathan Hurley On Oct. 13, 2015, 1:48 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39283/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 1:48 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan > Hurley, and Nate Cole. > > > Bugs: AMBARI-13407 > https://issues.apache.org/jira/browse/AMBARI-13407 > > > Repository: ambari > > > Description > ------- > > Added basic upgrade packs for Express Upgrade 2.2->2.3, 2.3->2.3+ > Ensured that have Config Packs for HDP 2.2 and 2.3 > Going to add configuration adjustment tasks in next patch. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/39283/diff/ > > > Testing > ------- > > > Thanks, > > Dmitro Lisnichenko > >
