> On Oct. 13, 2015, 3:50 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml, > > line 23 > > <https://reviews.apache.org/r/39283/diff/1/?file=1097519#file1097519line23> > > > > Shouldn't we name this EXPRESS to be consistent? Same with the file > > names; nonrolling-upgrade-2.3.xml should be express-upgrade-2.3.xml > > Alejandro Fernandez wrote: > My preference is to keep "Express" only on the UI.
Yes, but it will only add confusion for people looking at the code. Plus, when PATCH comes along, it could also be non-rolling (actually a mix) - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39283/#review102516 ----------------------------------------------------------- On Oct. 13, 2015, 1:48 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39283/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 1:48 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan > Hurley, and Nate Cole. > > > Bugs: AMBARI-13407 > https://issues.apache.org/jira/browse/AMBARI-13407 > > > Repository: ambari > > > Description > ------- > > Added basic upgrade packs for Express Upgrade 2.2->2.3, 2.3->2.3+ > Ensured that have Config Packs for HDP 2.2 and 2.3 > Going to add configuration adjustment tasks in next patch. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/39283/diff/ > > > Testing > ------- > > > Thanks, > > Dmitro Lisnichenko > >
