> On Oct. 13, 2015, 7:50 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml, > > line 23 > > <https://reviews.apache.org/r/39283/diff/1/?file=1097519#file1097519line23> > > > > Shouldn't we name this EXPRESS to be consistent? Same with the file > > names; nonrolling-upgrade-2.3.xml should be express-upgrade-2.3.xml
My preference is to keep "Express" only on the UI. > On Oct. 13, 2015, 7:50 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml, > > lines 137-140 > > <https://reviews.apache.org/r/39283/diff/1/?file=1097519#file1097519line137> > > > > What is this empty group? If we're using this as a way to stop the > > upgrade at a certain point, there are cleaner ways (like having a manual > > task). I used it as a placeholder so we wouldn't forget. Dmytro is working on how to handle Downgrades. > On Oct. 13, 2015, 7:50 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml, > > lines 142-143 > > <https://reviews.apache.org/r/39283/diff/1/?file=1097519#file1097519line142> > > > > You're missing `unlink_all_configs` which is required for downgrade > > from 2.3 to 2.2 Good catch. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39283/#review102516 ----------------------------------------------------------- On Oct. 13, 2015, 5:48 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39283/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 5:48 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan > Hurley, and Nate Cole. > > > Bugs: AMBARI-13407 > https://issues.apache.org/jira/browse/AMBARI-13407 > > > Repository: ambari > > > Description > ------- > > Added basic upgrade packs for Express Upgrade 2.2->2.3, 2.3->2.3+ > Ensured that have Config Packs for HDP 2.2 and 2.3 > Going to add configuration adjustment tasks in next patch. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/39283/diff/ > > > Testing > ------- > > > Thanks, > > Dmitro Lisnichenko > >
