----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39283/#review102530 -----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml (line 284) <https://reviews.apache.org/r/39283/#comment160221> Should use the direction marker in group and stage text. Also, the name of a group should be "like an enum" and not necessarily human-readable. "Upgrade Oozie" should be "UPGRADE_OOZIE_SHARELIB" or something. ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml (line 296) <https://reviews.apache.org/r/39283/#comment160222> Should use the direction marker in group and stage text. See also note on non-readable names. ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml (line 44) <https://reviews.apache.org/r/39283/#comment160223> Intent of name should be more like an enum name, not readable. ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml (line 161) <https://reviews.apache.org/r/39283/#comment160224> HBASE should be service display name. This is tokenized in code. ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml (line 177) <https://reviews.apache.org/r/39283/#comment160225> Yes, this is what name should look like :) ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml (line 219) <https://reviews.apache.org/r/39283/#comment160226> name ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml (line 234) <https://reviews.apache.org/r/39283/#comment160227> tokenize title - Nate Cole On Oct. 13, 2015, 1:48 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39283/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 1:48 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan > Hurley, and Nate Cole. > > > Bugs: AMBARI-13407 > https://issues.apache.org/jira/browse/AMBARI-13407 > > > Repository: ambari > > > Description > ------- > > Added basic upgrade packs for Express Upgrade 2.2->2.3, 2.3->2.3+ > Ensured that have Config Packs for HDP 2.2 and 2.3 > Going to add configuration adjustment tasks in next patch. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/39283/diff/ > > > Testing > ------- > > > Thanks, > > Dmitro Lisnichenko > >
