----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39589/#review103788 -----------------------------------------------------------
-1. The diff uploaded doesn't match the description of what you're trying to solve. According to the description you should be verifying whether the service specified is in the cluster, but not server-side actions. This is already done in the MasterHostResolver (if no hosts, the method returns null and should be skipped). ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java (line 126) <https://reviews.apache.org/r/39589/#comment161873> <> syntax is valid ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java (lines 213 - 217) <https://reviews.apache.org/r/39589/#comment161879> This doesn't make sense - server side actions have no hosts as they run on the Ambari server. - Nate Cole On Oct. 23, 2015, 9:17 a.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39589/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2015, 9:17 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan > Hurley, and Nate Cole. > > > Bugs: AMBARI-13541 > https://issues.apache.org/jira/browse/AMBARI-13541 > > > Repository: ambari > > > Description > ------- > > During EU, stages for non-existing services/components are also scheduled. So > EU fails on changing configs for missing services > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java > 6137285 > > ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml > 288b86a > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml > 9997c12 > > ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/ClusterGroupingTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/39589/diff/ > > > Testing > ------- > > Checked EU 2.1->2.3 with not all services installed, verified that configs > are changed and only tasks for existing services are generated. > > Patch does not introduce new unit failures. > > > Thanks, > > Dmitro Lisnichenko > >
