> On Oct. 23, 2015, 7:42 p.m., Nate Cole wrote: > > -1. The diff uploaded doesn't match the description of what you're trying > > to solve. According to the description you should be verifying whether the > > service specified is in the cluster, but not server-side actions. This is > > already done in the MasterHostResolver (if no hosts, the method returns > > null and should be skipped).
Yes, my bad. Will redo the patch. > On Oct. 23, 2015, 7:42 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java, > > lines 218-222 > > <https://reviews.apache.org/r/39589/diff/1/?file=1104093#file1104093line218> > > > > This doesn't make sense - server side actions have no hosts as they run > > on the Ambari server. You are right. I was attempting to refactor this code, but missed this usecase > On Oct. 23, 2015, 7:42 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java, > > line 126 > > <https://reviews.apache.org/r/39589/diff/1/?file=1104093#file1104093line126> > > > > <> syntax is valid Not sure what do you mean here. As I understand, the diamond operator is a preferred syntax (sugar) since it eliminates unnecessary repetition of type parameters, and we are anyway using language level 7. - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39589/#review103788 ----------------------------------------------------------- On Oct. 23, 2015, 4:17 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39589/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2015, 4:17 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan > Hurley, and Nate Cole. > > > Bugs: AMBARI-13541 > https://issues.apache.org/jira/browse/AMBARI-13541 > > > Repository: ambari > > > Description > ------- > > During EU, stages for non-existing services/components are also scheduled. So > EU fails on changing configs for missing services > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java > 6137285 > > ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml > 288b86a > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml > 9997c12 > > ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/ClusterGroupingTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/39589/diff/ > > > Testing > ------- > > Checked EU 2.1->2.3 with not all services installed, verified that configs > are changed and only tasks for existing services are generated. > > Patch does not introduce new unit failures. > > > Thanks, > > Dmitro Lisnichenko > >
