----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39589/#review104018 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java (lines 151 - 162) <https://reviews.apache.org/r/39589/#comment162208> I don't think you need to do all this work on getHostsForExecute() stage. UpgradeHelper has already determined if the add(...) method should be called based on null results of the resolver. It feels like you only need to do: case SERVER_ACTION: case CONFIGURE: // add the empty-host stage wrapper without the need for an extra method that is double-calling the MasterHostResolver method. - Nate Cole On Oct. 26, 2015, 8:59 a.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39589/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2015, 8:59 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan > Hurley, and Nate Cole. > > > Bugs: AMBARI-13541 > https://issues.apache.org/jira/browse/AMBARI-13541 > > > Repository: ambari > > > Description > ------- > > During EU, stages for non-existing services/components are also scheduled. So > EU fails on changing configs for missing services > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java > 6137285 > > ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml > 6d345a5 > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml > abf142e > > ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/ClusterGroupingTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/39589/diff/ > > > Testing > ------- > > Checked EU 2.1->2.3 with not all services installed, verified that configs > are changed and only tasks for existing services are generated. > > Patch does not introduce new unit failures. > > > Thanks, > > Dmitro Lisnichenko > >
