> On Oct. 23, 2015, 12:42 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java, > > line 126 > > <https://reviews.apache.org/r/39589/diff/1/?file=1104093#file1104093line126> > > > > <> syntax is valid > > Dmitro Lisnichenko wrote: > Not sure what do you mean here. As I understand, the diamond operator is > a preferred syntax (sugar) since it eliminates unnecessary repetition of type > parameters, and we are anyway using language level 7.
Sorry, I read this the wrong way - I thought you were adding the extra type, not removing it. Your change is correct. Dropping. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39589/#review103788 ----------------------------------------------------------- On Oct. 26, 2015, 8:59 a.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39589/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2015, 8:59 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan > Hurley, and Nate Cole. > > > Bugs: AMBARI-13541 > https://issues.apache.org/jira/browse/AMBARI-13541 > > > Repository: ambari > > > Description > ------- > > During EU, stages for non-existing services/components are also scheduled. So > EU fails on changing configs for missing services > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java > 6137285 > > ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml > 6d345a5 > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml > abf142e > > ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/ClusterGroupingTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/39589/diff/ > > > Testing > ------- > > Checked EU 2.1->2.3 with not all services installed, verified that configs > are changed and only tasks for existing services are generated. > > Patch does not introduce new unit failures. > > > Thanks, > > Dmitro Lisnichenko > >
