> On Feb. 24, 2016, 3:48 p.m., Nate Cole wrote: > > It seems like we should be going the other way. set/replace should support > > conditional attributes. The <transfer> already supports this (see > > HDP/2.3/config-upgrade.xml for dfs.namenode.rpc-address). <condition> > > should not be used
Got it Nate. I will update the patch accordingly. - Di ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43944/#review120509 ----------------------------------------------------------- On Feb. 24, 2016, 1:54 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43944/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2016, 1:54 p.m.) > > > Review request for Ambari and Alejandro Fernandez. > > > Bugs: AMBARI-15132 > https://issues.apache.org/jira/browse/AMBARI-15132 > > > Repository: ambari > > > Description > ------- > > <condition> in upgrade.xml currently only supports single property set. this > is to improve it to to support set/replace/transfer. The code change must be > backward compatible in order to not break the existing update-**.xml and > nonrolling-upgrade-**.xml. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java > a4dff2e > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java > 6b22f58 > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > 4ea8f15 > > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml > f345d12 > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml > 237da77 > > Diff: https://reviews.apache.org/r/43944/diff/ > > > Testing > ------- > > unit test > ran upgrade from Ambari 2.2 to Ambari trunk. > > > Thanks, > > Di Li > >
