> On Feb. 24, 2016, 7:35 p.m., Alejandro Fernandez wrote: > > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml, > > line 129 > > <https://reviews.apache.org/r/43944/diff/1/?file=1267519#file1267519line129> > > > > Do we already have granularity at the individual op level? > > E.g., > > <transfer ... if-key="" if-value="" /> > > <replace ... if-key="" if-value="" /> > > <set ... if-key="" if-value="" />
Hello Alejandro, Ambari trunk code currently only have conditions for transfter operation "delete". My initial thought was to do all the condition in the <condition> section. Based on Nate and your comments , I am updating the patch to have conditions done at operation level just like the ones you listed. - Di ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43944/#review120556 ----------------------------------------------------------- On Feb. 24, 2016, 1:54 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43944/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2016, 1:54 p.m.) > > > Review request for Ambari and Alejandro Fernandez. > > > Bugs: AMBARI-15132 > https://issues.apache.org/jira/browse/AMBARI-15132 > > > Repository: ambari > > > Description > ------- > > <condition> in upgrade.xml currently only supports single property set. this > is to improve it to to support set/replace/transfer. The code change must be > backward compatible in order to not break the existing update-**.xml and > nonrolling-upgrade-**.xml. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java > a4dff2e > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java > 6b22f58 > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > 4ea8f15 > > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml > f345d12 > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml > 237da77 > > Diff: https://reviews.apache.org/r/43944/diff/ > > > Testing > ------- > > unit test > ran upgrade from Ambari 2.2 to Ambari trunk. > > > Thanks, > > Di Li > >
