> On Feb. 25, 2016, 7:49 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java, > > lines 445-460 > > <https://reviews.apache.org/r/43944/diff/2/?file=1268445#file1268445line445> > > > > These properties can all be abstracted to Masked - Transfer and > > ConfigurationKeyValue ("set") already extend that. > > > > Also, probably want to remove <condition> from XML.
Hello Nate, I updated the code to mve the if-key, etc to the Masked. Please review. Thanks. - Di ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43944/#review120749 ----------------------------------------------------------- On Feb. 24, 2016, 10:32 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43944/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2016, 10:32 p.m.) > > > Review request for Ambari and Alejandro Fernandez. > > > Bugs: AMBARI-15132 > https://issues.apache.org/jira/browse/AMBARI-15132 > > > Repository: ambari > > > Description > ------- > > <condition> in upgrade.xml currently only supports single property set. this > is to improve it to to support set/replace/transfer. The code change must be > backward compatible in order to not break the existing update-**.xml and > nonrolling-upgrade-**.xml. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java > a4dff2e > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java > 6b22f58 > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > 1a5d4e7 > > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml > f345d12 > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml > 237da77 > > Diff: https://reviews.apache.org/r/43944/diff/ > > > Testing > ------- > > unit test > ran upgrade from Ambari 2.2 to Ambari trunk. > > > Thanks, > > Di Li > >
