> On Feb. 26, 2016, 2:27 a.m., Nate Cole wrote: > > This is very close - I think there's just one more thing to do (below).
Hello Nate, Please review the lastest patch where the ConfigureTask only does basic if attribute validation like you suggested (like has if-value but no if-key). and the ConfigureAction.java to perform the allow/disallow check. - Di ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43944/#review120815 ----------------------------------------------------------- On Feb. 25, 2016, 9:34 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43944/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2016, 9:34 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Nate Cole. > > > Bugs: AMBARI-15132 > https://issues.apache.org/jira/browse/AMBARI-15132 > > > Repository: ambari > > > Description > ------- > > <condition> in upgrade.xml currently only supports single property set. this > is to improve it to to support set/replace/transfer. The code change must be > backward compatible in order to not break the existing update-**.xml and > nonrolling-upgrade-**.xml. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java > a4dff2e > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java > 6b22f58 > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > 1a5d4e7 > > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml > f345d12 > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml > 237da77 > > Diff: https://reviews.apache.org/r/43944/diff/ > > > Testing > ------- > > unit test > ran upgrade from Ambari 2.2 to Ambari trunk. > > > Thanks, > > Di Li > >
