----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43944/#review120978 -----------------------------------------------------------
Fix it, then Ship it! Nice work! Just remove dead comments and I'm all set on this review. Thanks for taking this up, it really helps the consistency and readability of the upgrade packs. ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java (lines 325 - 329) <https://reviews.apache.org/r/43944/#comment182531> remove commented dead-code - Nate Cole On Feb. 26, 2016, 4:47 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43944/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2016, 4:47 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Nate Cole. > > > Bugs: AMBARI-15132 > https://issues.apache.org/jira/browse/AMBARI-15132 > > > Repository: ambari > > > Description > ------- > > <condition> in upgrade.xml currently only supports single property set. this > is to improve it to to support set/replace/transfer. The code change must be > backward compatible in order to not break the existing update-**.xml and > nonrolling-upgrade-**.xml. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java > e77cf36 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java > a4dff2e > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java > 6b22f58 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java > ce87668 > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > 1a5d4e7 > > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/config-upgrade.xml > f345d12 > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml > 237da77 > > Diff: https://reviews.apache.org/r/43944/diff/ > > > Testing > ------- > > unit test > ran upgrade from Ambari 2.2 to Ambari trunk. > > > Thanks, > > Di Li > >
