eric-milles commented on code in PR #111:
URL: https://github.com/apache/ant-ivy/pull/111#discussion_r2809656768
##########
src/java/org/apache/ivy/plugins/parser/xml/XmlModuleDescriptorParser.java:
##########
@@ -722,6 +716,17 @@ public void mergeExcludes(ExcludeRule[] excludeRules) {
}
}
+ private void mergeNamespaces(Map<String, String> namespaces) {
+ if (namespaces != null && !namespaces.isEmpty()) {
+ for (Map.Entry<String, String> entry : namespaces.entrySet()) {
+ Message.debug("Merging extra attribute namesapce: " +
entry);
+ if
(getMd().getExtraAttributesNamespaces().get(entry.getKey()) == null) {
Review Comment:
As the issue describes and the test indicates, when a parent module is
merged in and makes use of namespaces, they are required to be carried across
so that the resulting, delivered ivy.xml is usable. The example shows
`xmlns:m="http://ant.apache.org/ivy/maven"` declared in parent module and when
a merged xml is written, there is use of `m:...` but no declaration of the
namespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
