bodewig commented on code in PR #111:
URL: https://github.com/apache/ant-ivy/pull/111#discussion_r2809692221
##########
src/java/org/apache/ivy/plugins/parser/xml/XmlModuleDescriptorParser.java:
##########
@@ -722,6 +716,17 @@ public void mergeExcludes(ExcludeRule[] excludeRules) {
}
}
+ private void mergeNamespaces(Map<String, String> namespaces) {
+ if (namespaces != null && !namespaces.isEmpty()) {
+ for (Map.Entry<String, String> entry : namespaces.entrySet()) {
+ Message.debug("Merging extra attribute namesapce: " +
entry);
+ if
(getMd().getExtraAttributesNamespaces().get(entry.getKey()) == null) {
Review Comment:
I get that.
If the module you merge the parent to defines the prefix `m` for the
namespace URI `https://ant.apache.org/something` your code will not add the
parent's namespace. And if the module you merge the parent into defines the
prefix `maven` for the namespace URI `http://ant.apache.org/ivy/maven` you
would not simply re-use the already existing prefix.
The namespace URI is all that is important for XML, so you need to look for
the matching URI and not the prefix - which is irrelevant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
