eric-milles commented on code in PR #111:
URL: https://github.com/apache/ant-ivy/pull/111#discussion_r2809660914
##########
src/java/org/apache/ivy/plugins/parser/xml/XmlModuleDescriptorUpdater.java:
##########
@@ -409,13 +410,22 @@ public void startElement(String uri, String localName,
String qName, Attributes
// copy
write("<" + qName);
- for (int i = 0; i < attributes.getLength(); i++) {
- write(" " + attributes.getQName(i) + "=\""
- + substitute(settings, attributes.getValue(i)) +
"\"");
+ if (options.isMerge() && path.equals("ivy-module")) {
+ for (int i = 0, n = attributes.getLength(); i < n; i += 1)
{
+ if (attributes.getQName(i).startsWith("xmlns:"))
continue;
+ write(" " + attributes.getQName(i) + "=\"" +
substitute(settings, attributes.getValue(i)) + "\"");
+ }
+ Map<String, String> namespaces =
options.getMergedDescriptor().getExtraAttributesNamespaces();
+ for (Map.Entry<String, String> namespace :
namespaces.entrySet()) {
Review Comment:
`path.equals("ivy-module")` means we are processing the `ivy-module` node.
This is where the namespaces are found (and merged by this change):
```xml
<ivy-module
version="2.0"
xmlns:m="http://ant.apache.org/ivy/maven";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
