bodewig commented on code in PR #111:
URL: https://github.com/apache/ant-ivy/pull/111#discussion_r2809697978
##########
src/java/org/apache/ivy/plugins/parser/xml/XmlModuleDescriptorUpdater.java:
##########
@@ -409,13 +410,22 @@ public void startElement(String uri, String localName,
String qName, Attributes
// copy
write("<" + qName);
- for (int i = 0; i < attributes.getLength(); i++) {
- write(" " + attributes.getQName(i) + "=\""
- + substitute(settings, attributes.getValue(i)) +
"\"");
+ if (options.isMerge() && path.equals("ivy-module")) {
+ for (int i = 0, n = attributes.getLength(); i < n; i += 1)
{
+ if (attributes.getQName(i).startsWith("xmlns:"))
continue;
+ write(" " + attributes.getQName(i) + "=\"" +
substitute(settings, attributes.getValue(i)) + "\"");
+ }
+ Map<String, String> namespaces =
options.getMergedDescriptor().getExtraAttributesNamespaces();
+ for (Map.Entry<String, String> namespace :
namespaces.entrySet()) {
+ write(" xmlns:" + namespace.getKey() + "=\"" +
substitute(settings, namespace.getValue()) + "\"");
+ }
+ } else {
+ for (int i = 0, n = attributes.getLength(); i < n; i += 1)
{
Review Comment:
you changed the existing` i++` to `i+=1` because you like it better.
Personally I'd prefer `i++`.
You are completely right. It does not change the functionality so there's
not been any reason to replace the `i++` that's been there.
The thing I said in the other PR. Please avoid us getting hung up on taste
issues by accepting what is there unless it is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
