On 13/05/2020 11:28, Branko Čibej wrote:
On 13.05.2020 10:41, Mladen Turk wrote:
1. Remove all APU_XXX references
    Since the apr-util is apr
    remove all APU_XXX defines and API

This will cause any coded that's upgrading from apr/apu 1.x to apr 2.x
and uses those symbols to break. That's an unnecessary change of
backwards compatibility.


Not sure about the usage of APU_DSO_MODULE_BUILD or APU_MODULE_DECLARE_DATA,
but those are the least important things. If you think they are needed then OK.


2. Netware and OS/2
    Both platforms are dead for years
    IMHO bunch of relic code no one use
3. https://svn.apache.org/viewvc/apr/apr/trunk/include/apu.h?view=markup
    More then 10 years ago ...

See above about existing code that uses apr-util 1.x (q.v., Subversion).
There's no reason to break API compatibility on that level and forcing
all downstream users that want to keep supporting both 1.x and 2.x from
peppering their code with #if's.


Did not talk about breaking API compatibility, but about cleaning
up dead code nobody touched for 12+ years.

Maybe that's the reason why it's sitting in the repo for 10 years.


Regards
--
^TM

Reply via email to