Here’s your digest for today! #ariatosca undefined: <@U4RAXBZ1Q> Im taking the website issue undefined: I don't really see any issues with Github's diff tool. If it's good enough for *everyone* we should probably be okay with it as well.. undefined: but it sounds like its not good enough for everyone. thanks <@U53NR8XFF> undefined: we used to use reviewboard when most apache projects were on svn after git migration, I find git review to be good enuf but maybe there are better tools out there. Reviewboard wasn’t bad in the old svn times. Diff topic: <@U4RAXBZ1Q> what’s the outcome of incubator gitbox migration proposal ? undefined: i need to read the emails. and see. i suspect someone may have attempted to shut down the conversation undefined: i think github diff really is fine, especially for publicly reading the reviews. however, reviewers could always supplement their own tools according to needs. especially i would imagine that many code reviews might require the reviewer to try the branch out locally, so they would have to check it out anyway. when you have it locally there's so much more you can do that web apps would never be able to duplicate properly. undefined: u can use ur IDE <@U53P75YTD> to compare ur local branch with a PR i use PyCharm and its pretty good i can compare my local code vs a remote git repo undefined: i like Eclipse (with PyDev plugin). but really all good IDEs could do this. and yes, you can compare remotely, too undefined: as a Apache Committer u r eligible for a free commercial JetBrains license - i love Pycharm u would never ever go back to Eclipse again undefined: well, since i also have a bunch of projects in Java and C/C++ i prefer to have a multilingual IDE. also, i always prefer free software... undefined: CLion is what u need u get a free commercial license from jetbrains for all their software with ur apache committer hat on heh, i work on MxNet which is Scala, C/C++, Python IntelliJ has been working fine for me to deal with all the multi langs MxNet also has Perl, Julia, Javascript undefined: "free commercial license" does not mean free software :slightly_smiling_face: undefined: its not undefined: eclipse works great for me, i see no reason to change also i think it's diff tools are better than all the rest undefined: well great undefined: [UPDATE] nice progress on parser testing.
i'm implementing my testing philosophy based on reusable "mechanisms" (in `tests/mechanisms`) that will be considered to be very stable and "core", with the test cases remaining lightweight and as free as possible from any specialized mocking. the mechanism should be able to handle the test cases with ease, otherwise it must be improved (or the test re-thought). so far so good. i started with tests for TOSCA `imports`, because they are more complex in terms of mocking: you need a repository (web site) to serve the imported files. to do this i am now including Tornado as a test dependency, and created a simple WebServer test mechanism that makes it a piece of cake, very simple to create a fixture that serves HTTP (and it works in concurrent testing, too, by providing a free existing port per web server) i've also written tests for `metadata` just to try something "easy". always amazing how valuable testing is: i've already fixed various little papercut bugs in the parser having to do with YAML types and unicode. btw, i'm being careful to have the unicode-specific tests separate, because i imagine that some of the non-ARIA parsers we will test with this might very well choke on unicode while being OK on everything else. so i want to give them some opportunity to succeed. :slightly_smiling_face: #general undefined: It can be primary, but everything that happens there still has to be mirrored to Apache. Either through notifications set to go to appropriate mailing lists or git commits mirrored to Apache GIT
