I could add a #ifdef around this, however gRPC itself doesn't appear to provide a version macro. So the person building flight would have to define this option themselves.
We also need a macro to define what namespace we get the new API from -- it changes in gRPC 1.32 and above. How about I go ahead and put a few commits on top of my current PR to make this a bit more concrete. On Wed, Oct 7, 2020 at 12:35 PM Antoine Pitrou <anto...@python.org> wrote: > > Or perhaps we (meaning James :-)) can add an #ifdef-based switch. > > There's no need to penalize users of older gRPCs for a rather optional > feature (if you can call disabling a security verification a feature, of > course ;-)). > > Regards > > Antoine. > > > Le 07/10/2020 à 21:33, Wes McKinney a écrit : > > Given Google's "live at head" mantra, in principle I don't have a > > problem with requiring a < 1 year old version of gRPC > > > > On Wed, Oct 7, 2020 at 2:23 PM Antoine Pitrou <anto...@python.org> > wrote: > >> > >> > >> Le 07/10/2020 à 21:19, James Duong a écrit : > >>> Hi Neal, > >>> > >>> Are you the release manager for 2.0? > >>> I've been working on the task to disable server verification in Flight > >>> clients, and it appears we'll need > >>> to update the minimum gRPC version to at least 1.27 to support this. > >>> > >>> Would it be OK to do this for the 2.0. release? It looks like we also > need > >>> to update Ursa configurations here: > >>> > https://github.com/ursa-labs/ursabot/blob/e958c5f95b31e98108df54cf13596c4fde944c3a/projects/arrow/docker/conda-cpp.txt#L19 > >> > >> IMHO that implies a lot of potential issues to watch for, at the last > >> minute before a release. Personally, I'd rather see this in 3.0. > >> > >> Regards > >> > >> Antoine. > -- *James Duong* Lead Software Developer Bit Quill Technologies Inc. Direct: +1.604.562.6082 | jam...@bitquilltech.com https://www.bitquilltech.com This email message is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure, or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. Thank you.
