On Wed, 7 Oct 2020 12:46:22 -0700 James Duong <jam...@bitquilltech.com> wrote: > I could add a #ifdef around this, however gRPC itself doesn't appear to > provide a version macro.
Hmm, can you please report an issue upstream? This could be more generally useful. > We also need a macro to define what namespace we get the new API from -- it > changes in gRPC 1.32 > and above. Note you can perhaps get around those version issues using template hackery. We already did that here: https://github.com/apache/arrow/blob/master/cpp/src/arrow/filesystem/s3fs.cc#L462-L477 Not pretty and annoying to get right, but better than nothing :-) > How about I go ahead and put a few commits on top of my current PR to make > this a bit more concrete. Please do! Regards Antoine.
